refactor: resolved all maker's todo #713
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #713 +/- ##
===========================================
+ Coverage 68.87% 80.77% +11.89%
===========================================
Files 35 50 +15
Lines 4932 14692 +9760
===========================================
+ Hits 3397 11867 +8470
- Misses 1535 2825 +1290 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
@0xEgao is this ready for review? |
Collaborator
Author
|
0xEgao
force-pushed
the
maker-todo
branch
3 times, most recently
from
b3eb834 to
cf74292
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr aims to resolve all marked TODO in
makermodule, and fixes #703 partiallyTODO's fixed-:
1-) Encapsulated the maker's watcher initialization into an api named as
start_maker_watch_serviceto avoid code repetition.2-) Created
nostr_coinswapmodule to transfer bunch of api's from maker'sserverto a common place.3-) Refactored the v2-maker logic to create ConnectionState after receiving
SwapDetailsfrom Taker, asGetOffermessage usually contains empty string inswap-id.4-) Uncommented a marked todo in maker
handlers2module.